From e51895fa18a9599a3173975679d39bb691e69afb Mon Sep 17 00:00:00 2001
From: Konstantin Lampalzer <konstantin.lampalzer@twinformatics.at>
Date: Wed, 25 Sep 2024 21:54:46 +0200
Subject: [PATCH] cmake: add default Werror, extract version only from
 GITHUB_REF if tag

---
 .github/workflows/test.yaml | 2 +-
 CMakeLists.txt              | 2 +-
 cmake/Versioning.cmake      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index 986dc29..fb0bcce 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -20,7 +20,7 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Configure CMake
-        run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DCMAKE_CXX_FLAGS="-Werror"
+        run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}
 
       - name: Build
         run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}}
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 007b56b..e39cf16 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -24,7 +24,7 @@ project(
   VERSION ${TAG_VERSION_MAJOR}.${TAG_VERSION_MINOR}.${TAG_VERSION_PATCH}
 )
 
-add_compile_options(-Wall -Wextra -Wpedantic)
+add_compile_options(-Wall -Wextra -Wpedantic -Werror)
 
 set(PACKAGE_VERSION ${TAG_VERSION_MAJOR}.${TAG_VERSION_MINOR}.${TAG_VERSION_PATCH})
 
diff --git a/cmake/Versioning.cmake b/cmake/Versioning.cmake
index 7665011..d659c5c 100644
--- a/cmake/Versioning.cmake
+++ b/cmake/Versioning.cmake
@@ -8,7 +8,7 @@ if(GIT_EXECUTABLE)
         OUTPUT_STRIP_TRAILING_WHITESPACE
     )
 
-    if(DEFINED ENV{GITHUB_REF})
+    if(DEFINED ENV{GITHUB_REF} AND ENV{GITHUB_REF_TYPE} EQUAL "tag")
         set(TAG_VERSION $ENV{GITHUB_REF})
         message(STATUS "Extracted version from GITHUB_REF")
     endif()