compAIR/libcreate

Fork 1

Feature/ci packing #2

Merged

Kola50011 merged 13 commits from feature/ci-packing into master

2024-09-26 09:18:37 +02:00

Kola50011 commented

2024-09-24 09:17:35 +02:00

(Migrated from github.com)

No description provided.

christoph-heiss (Migrated from github.com) reviewed 2024-09-25 13:09:56 +02:00

christoph-heiss (Migrated from github.com) left a comment

Apart from the -Werror stuff and the CI failure due to the cmake invocation, LGTM.

Apart from the `-Werror` stuff and the CI failure due to the cmake invocation, LGTM.

.github/workflows/test.yaml

christoph-heiss (Migrated from github.com) commented

2024-09-25 13:08:12 +02:00

I'd rather add the -Werror directly in the CMake setup add the top to the add_compile_options(..) call.

Also, the CI fails, as cmake needs to be passed the path to the source directory as first unnamed argument.

      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} ${{github.workspace}}

I'd rather add the `-Werror` directly in the CMake setup add the top to the `add_compile_options(..)` call. Also, the CI fails, as `cmake` needs to be passed the path to the source directory as first unnamed argument. ```suggestion run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} ${{github.workspace}} ```

ci/entrypoint.sh

christoph-heiss (Migrated from github.com) commented

2024-09-25 13:08:40 +02:00

Same as above for the CI workflow.

cmake -B /libcreate/build -S /libcreate -DCMAKE_BUILD_TYPE=Release

Same as above for the CI workflow. ```suggestion cmake -B /libcreate/build -S /libcreate -DCMAKE_BUILD_TYPE=Release ```

christoph-heiss (Migrated from github.com) reviewed 2024-09-25 13:19:48 +02:00

CMakeLists.txt

christoph-heiss (Migrated from github.com) commented

2024-09-25 13:19:47 +02:00

add_compile_options(-Wall -Wextra -Wpedantic -Werror)

```suggestion add_compile_options(-Wall -Wextra -Wpedantic -Werror) ```

Kola50011 commented

2024-09-25 22:08:36 +02:00

(Migrated from github.com)

Should be good now. Pls approve and merge

christoph-heiss (Migrated from github.com) approved these changes 2024-09-26 09:17:58 +02:00

No reviewers

christoph-heiss

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: compAIR/libcreate#2

No description provided.

Rows
Columns